Add $code parameter to disconnect, reset SEQ on new session, don't re-fetch websocket_url when resuming, make 1000 & 1001 resumable

incognico commented 3 years ago

Add $code parameter to $discord->disconnect() to allow for normal closures from a client, e.g. to gracefully close with 1000 after SIGINT
Reset SEQ on new sessions so the heartbeating does not use the old SEQ ID until the correct one is received again
Don't re-fetch the websocket_url when resuming. Since a while the Mojo UA sometimes gives me a Premature connection close in sub gateway, not sure why - so this is a workaround. But I'm pretty sure that if this url ever changes it would require a new session anyways so why not use the cached one on resume.
Make 1000 & 1001 resumable (makes "CloudFlare WebSocket proxy restarting" resumable) Should be fine, the docs only mention a session invalidation on those codes if we close the connection with one of those.

incognico commented 3 years ago

ccfbf90 slipped in here. Revert that one (or not), as you wish.

vsTerminus commented 3 years ago

I've made some of these changes in my local copy. I'll likely end up just closing the pull request once I've pushed my own changes, but thank you, this was helpful.

vsTerminus commented 2 years ago

$code parameter added in fa2ed0430114df3e0523d9932a58c8711737ad99

vsTerminus / Mojo-Discord

Add $code parameter to disconnect, reset SEQ on new session, don't re-fetch websocket_url when resuming, make 1000 & 1001 resumable #42