search

vsariola / sointu

Fork of 4klang that can target 386, amd64 and WebAssembly. Tools run on Windows, Mac & Linux
MIT License
239 stars 15 forks source link

Recording from FL Studio using the VST plugin crashes FL Studio #95

Closed LeStahL closed 11 months ago

LeStahL commented 12 months ago

When recording sointu-test.zip using Sointu 9db6ecb3dafad09f473743748ea17c9019631be8 as VST plugin and FL Studio 20.8.3 (build 2304) 64-bit, FL Studio crashes along with Sointu after stopping the recording.

vsariola commented 12 months ago

That sounds like a bug in the code that constructs the patterns from the note data. I'll investigate.

LeStahL commented 12 months ago

Let me know if you need any more info :)

vsariola commented 12 months ago

The "recording" functionality was kinda half-assed, so it's not really surprising if there's an array index-out-of-bounds somewhere or something.

vsariola commented 12 months ago

Uh oh, I installed the latest FL Studio (v21.0.3 build 3517) and it crashes right after adding sointu to the project. The GUI blinks on screen and then FL Studio is gone. No crash logs or anything.

vsariola commented 12 months ago

Ok, it's probably something in the vst2 package I use. I compiled their "demoplugin.go" and added that as an effect to a FL project and it also crashes FL immediately.

vsariola commented 12 months ago

Update: can you try if the latest version in master fixes the issue for you? You should be able to find the binary under Actions.

My crashes were a separate issue, but that required patching the vst2 package; I've sent a pull request there.

vsariola commented 12 months ago

Oh, the crashes seem to be due to FruityLoops not telling me the BPM when I ask it to; this is not solved yet, but you should be able to set the BPM in sointu side manually to match the BPM in the host side. This should give you proper recordings.

vsariola commented 12 months ago

...and Sergei merged my patches to the vst2 package, so I was able to fix getting the BPM from FruityLoops! The latest version should ("should") be working in FruityLoops, but please test. If the latest version in master branch works for you, I'll close this issue.

LeStahL commented 11 months ago

I tested the binaries and they fully work as expected :) Thanks for looking into it!

vsariola commented 11 months ago

thanks! closing this :) let me know if you find new bugs!