search

vsaveris / trading-technical-indicators

Trading Technical Indicators python library
https://www.trading-technical-indicators.org/
MIT License
114 stars 33 forks source link

Correct psar trade signal #35

Closed haphan closed 3 years ago

haphan commented 3 years ago

@vsaveris It looks like the trade signal is reversed here.

vsaveris commented 3 years ago

Thanks @haphan, I will take a look of your change soon.

vsaveris commented 3 years ago

Great catch, according the Technical Analysis from A to Z book, where the implementation is based, the interpretation for the PSAR indicator is: Close Long when price falls below the indicator Close Short when price rises above the indicator

Fix is accepted.