search

vsavkin / angulardart-sample-app

A sample Web application built using AngularDart
Other
102 stars 27 forks source link

updating to angular 0.9.11 #15

Closed adam-singer closed 10 years ago

adam-singer commented 10 years ago

some updates to latest angular. Unsure about the following exception and I dont have a karma setup to run the unit tests.. so take patch with caution 

discarding handle for [Route: list]
'package:angular/core/scope.dart': Failed assertion: line 299 pos 12: 'isAttached' is not true.

STACKTRACE:
#0      Scope.destroy (package:angular/core/scope.dart:299:12)
#1      NgViewDirective._cleanUp (package:angular/routing/ng_view.dart:132:19)
#2      NgViewDirective._show.<anonymous closure> (package:angular/routing/ng_view.dart:108:15)
#3      _rootRunUnary (dart:async/zone.dart:730)
#4      _ZoneDelegate.runUnary (dart:async/zone.dart:462)
#5      _onRunUnary.<anonymous closure> (package:angular/core/zone.dart:70:61)
#6      NgZone._onRunBase (package:angular/core/zone.dart:54:16)
#7      _onRunUnary (package:angular/core/zone.dart:70:15)
#8      _ZoneDelegate.runUnary (dart:async/zone.dart:462)
#9      _CustomizedZone.runUnary (dart:async/zone.dart:667)
#10     _BaseZone.runUnaryGuarded (dart:async/zone.dart:582)
#11     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:333)
#12     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263)
#13     _SyncBroadcastStreamController._sendData (dart:async/broadcast_stream_controller.dart:337)
#14     _BroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:228)
#15     Router._leaveCurrentRouteHelper (package:route_hierarchical/client.dart:654:48)
#16     Router._leaveCurrentRouteHelper (package:route_hierarchical/client.dart:656:46)
#17     Router._leaveCurrentRoute (package:route_hierarchical/client.dart:645:43)
#18     Router._leaveOldRoutes (package:route_hierarchical/client.dart:512:30)
#19     Router._processNewRoute (package:route_hierarchical/client.dart:487:27)
#20     Router._route.<anonymous closure> (package:route_hierarchical/client.dart:469:32)
#21     _rootRunUnary (dart:async/zone.dart:730)
#22     _ZoneDelegate.runUnary (dart:async/zone.dart:462)
#23     _onRunUnary.<anonymous closure> (package:angular/core/zone.dart:70:61)
#24     NgZone._onRunBase (package:angular/core/zone.dart:54:16)
#25     _onRunUnary (package:angular/core/zone.dart:70:15)
#26     _ZoneDelegate.runUnary (dart:async/zone.dart:462)
#27     _CustomizedZone.runUnary (dart:async/zone.dart:667)
#28     _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:488)
#29     _Future._propagateToListeners (dart:async/future_impl.dart:571)
#30     _Future._completeWithValue (dart:async/future_impl.dart:331)
#31     _Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:393)
#32     _rootRun (dart:async/zone.dart:719)
#33     _ZoneDelegate.run (dart:async/zone.dart:453)
#34     _onScheduleMicrotask.<anonymous closure> (package:angular/core/zone.dart:74:39)
#35     _rootRun (dart:async/zone.dart:723)
#36     _ZoneDelegate.run (dart:async/zone.dart:453)
#37     NgZone._finishTurn (package:angular/core/zone.dart:94:23)
#38     NgZone._onRunBase (package:angular/core/zone.dart:61:43)
#39     _onRunUnary (package:angular/core/zone.dart:70:15)
#40     _ZoneDelegate.runUnary (dart:async/zone.dart:462)
#41     _CustomizedZone.runUnary (dart:async/zone.dart:667)
#42     _BaseZone.runUnaryGuarded (dart:async/zone.dart:582)
#43     _BaseZone.bindUnaryCallback.<anonymous closure> (dart:async/zone.dart:608)
vsavkin commented 10 years ago

Thanks for the pull request. I've just merged it. It looks like the the exception isn't caused by the pull request, so I'm going to look into it tomorrow.

adam-singer commented 10 years ago

@vsavkin awesome! I use this sample often as reference, especially around the unit testing of angulardart. Please keep it up :+1: