search

vsavkin / router-store

51 stars 6 forks source link

RouteNavigationPayload is not serializable #10

Closed s-ve closed 7 years ago

s-ve commented 7 years ago

Currently, RouteNavigationPayload stores a reference to a RouterStateSnapshot instance.

RouterStateSnapshot is likely to contain circular references (e.g. child routes have pointers to their parent) and thus it cannot be encoded as a JSON string properly.

Wouldn't this problem prevent navigation actions from being serialized and "replayed" at a later point in time ?

mkennedy3000 commented 7 years ago

If I am correct @vsavkin, all further development for this will be done inside @ngrx/platform in the @ngrx/router-store module. If this is still an issue I would raise it there and close this one.

vsavkin commented 7 years ago

Yup, could you open the issue in @ngrx/platform?

I'll update the project's readme to point everyone to @ngrx/platform

s-ve commented 7 years ago

I've opened a new issue here.