vsch / flexmark-java

CommonMark/Markdown Java parser with source level AST. CommonMark 0.28, emulation of: pegdown, kramdown, markdown.pl, MultiMarkdown. With HTML to MD, MD to PDF, MD to DOCX conversion modules.
BSD 2-Clause "Simplified" License
2.29k stars 272 forks source link

New release requires Java 11 or greater. #494

Open vsch opened 2 years ago

vsch commented 2 years ago

I could not get docx4j to pass tests with Java 8 and gave up for now.

Updated the project to Java 11 and released 0.64.0

If this is a show stopper for anyone please let me know and I will see if I can figure out how to keep Java 8 going a bit longer.

alexkrapf commented 2 years ago

I usually try to stay on older language levels for a while. In my project I just transitioned to Java 9 to use module features but I have stayed away from Java 11 features. I could isolate the Java 11 requirement to the module that uses flexmark, but I would then have a Java 11 dependency for just one module at runtime. Do what you have to do but I think it could break a lot of people, particularly crossing the Java 8/9 boundary.

kiranshila commented 2 years ago

Hey! First off, thank you for the excellent library! I maintain a wrapper in the Clojure language, which strives to maintain backwards compat as much as possible. As such, I would much prefer if we'd stay on Java 8 for as long as we can. I don't know how many of my users are on Java 8, but it aligns with the strong "updates shouldn't break anything" ethos.

znerd commented 2 years ago

Wouldn't it make sense to:

That would be compatible with the Semantic Versioning approach, which is more or less a de facto standard nowadays.

cweijan commented 2 years ago

I used the latest version, but unfortunately it only supports jdk11, so I returned 6.2.2.