vsch / flexmark-java

CommonMark/Markdown Java parser with source level AST. CommonMark 0.28, emulation of: pegdown, kramdown, markdown.pl, MultiMarkdown. With HTML to MD, MD to PDF, MD to DOCX conversion modules.
BSD 2-Clause "Simplified" License
2.26k stars 269 forks source link

Html5Entities class and entities.properties files should be in same module #549

Open alexkrapf opened 1 year ago

alexkrapf commented 1 year ago

Still a great project, just something I stumbled over in 0.64.0 release:

When using modules, embedded resources and classes that use these resources should be in the same module. Html5Entities is part of util-sequence and entities.properties is part of util.html. That causes a NullPointerException when I try to resolve an entity name.

I believe that it would make logical sense to move the Html5Entities class into the util.html module, but I might be wrong and there might be a good reason to keep it where it is. In that case the resource file should be moved.