search

vsch / idea-multimarkdown

Markdown language support for IntelliJ IDEA.
https://plugins.jetbrains.com/plugin/7896-markdown-navigator
Apache License 2.0
813 stars 129 forks source link

Latest version : All options in plugin settings cleared. Reset to defaults does not work. #801

Closed martinlanton closed 4 years ago

martinlanton commented 4 years ago

Numbered lists as well as everything nested in them (ex : bullet point lists made using the * character and nested inside numbered lists) do not display as they should in the latest release of the plugin.

vsch commented 4 years ago

@martinlanton, your settings are messed up. Please reset to defaults or restore them from VCS if you have them under VCS.

See: https://github.com/vsch/idea-multimarkdown/issues/796#issuecomment-568581439

martinlanton commented 4 years ago

@vsch I never even touched the settings, I'm using the default ones.

vsch commented 4 years ago

@martinlanton, did you have a previous version of the plugin installed or is 2.9.9 the first installation?

Previous release version was not compatible with 2019.3 beta and the IDE would recommend installing a really old version. Installing that would blow away the settings.

I am also not sure if the incompatible version only got far enough to mess up the settings. I have to double check that.

martinlanton commented 4 years ago

@vsch I had a previous version installed when I was on 2019.2, then switched to pycharm 2019.3 and as soon as it was available, I upgraded to 2.9.9.

I tried using the button provided to reset the settings to default, unfortunately, as I mentioned before, the current settings seem to be the default one, as clicking on that button didn't change anything.

vsch commented 4 years ago

@martinlanton, in that case could you paste a screenshot of your parser settings: Languages & Frameworks > Markdown > Parser

And also give me an example of your numbered list that do not display properly, preferably pasted into fenced code in the comment so I can see the raw text.

martinlanton commented 4 years ago

Here are the settings :

settings

Here are the examples, none of those work : https://gist.github.com/martinlanton/a54c147376f30a2041267fb8db8f53f4

vsch commented 4 years ago

@martinlanton, all your settings are cleared. If you do a settings reset on the main markdown settings panel then come back to this panel you should see defaults restored.

This is causing your parser to not process anything properly. The lists are set to 4 spaces fixed which is not the correct setting for defaults. This is the default for historical reasons but no longer the default setting.

martinlanton commented 4 years ago

@vsch as I just mentioned, resetting the main markdown settings doesn't seem to work, it doesn't do anything.

martinlanton commented 4 years ago

I just uninstalled and reinstalled the plugin, and this didn't change anything. Also tried to reset the settings after reinstalling, and this didn't change anything either.

vsch commented 4 years ago

@martinlanton, can you please send me the project settings files form the plugin. They are located in the .idea sub-directory of the project directory and start with markdown-navigator.

Also if you export Markdown Navigator settings (in the same menu as reset) and send that file to me vladimir at vladsch.com. Normally, only the latter would be enough but in this case I would like to see actual saved setting files for the plugin.

I want to use them for testing to see what causes this.

I will test them on pycharm so I have exact conditions of your system.

martinlanton commented 4 years ago

@vsch That's sent, thank you for looking into this! PS : I'm using pycharm build #PC 193.5233.109 on windows 10, if that can help

vsch commented 4 years ago

@martinlanton, thank you for sticking to it and sending me your settings. I appreciate you taking the time to give me a chance to figure out what #@$@#@ is going on.

BTW, reinstalling the plugin does not delete the plugin settings for the IDE nor the project so it does not help. I will figure out how to add a test on installation for existing settings and prompt to use them or discard them so re-install will have a chance of initializing the system.

This is what reset was intended to do--Reset to installation defaults.

I will let you know as soon as I have a fix and probably a workaround for this issue.

martinlanton commented 4 years ago

Thanks @vsch

vsch commented 4 years ago

@martinlanton, found the bug. Fixed and added code to detect invalid settings on load and correct them without needing to reset settings.

I will make a new release shortly. There are a few show stopper bugs that made it into the last release, including this one.

vsch commented 4 years ago

@martinlanton, fixed plugin released. Thank you for providing me with your settings. They were indispensable. I must have copied them over to my test project two or three dozen times before I got the fix working.

martinlanton commented 4 years ago

I'm glad I could help! I will download the new version! Thanks a lot!

EDIT : The new version fixed the problem! Thanks again!