vsco / bazel-toolchains

A collection of Bazel C++ build infrastructure based on Chromium's LLVM toolchain.
Apache License 2.0
38 stars 8 forks source link

macOS Fixes / Larger Build Matrix #15

Closed promiseofcake closed 6 years ago

promiseofcake commented 6 years ago

This will fail for OSX builds with Bazel <= 0.12.0, I am not sure that statically linking gtest is the correct approach here to because this issue has a greater scope in other projects.

Internal ref: ML-1330

promiseofcake commented 6 years ago

~3764b99 replaces the -B/usr/bin argument to clang and specifying a search path of tools/cpp/tool_wrappers/mac which has a symlink to /usr/bin/ld to reduce the unintended consequences of including the larger scoped path.~

Reverting 3764b99 due to it's inability to be utilized by other workspaces. This ld workaround might be overkill and might swap back to including all of /usr/bin in the search path since prior to Bazel 0.13.0, the user's entire PATH was leveraged for our Darwin builds, so I don't see this as a huge regression.