Needs explicit deps on @org_chromium_libcxx

vsco / bazel-toolchains

A collection of Bazel C++ build infrastructure based on Chromium's LLVM toolchain.

Apache License 2.0

38 stars 8 forks source link

Needs explicit deps on @org_chromium_libcxx #7

Closed nicolov closed 6 years ago

nicolov commented 7 years ago

Hey there, thanks for the great work here.

I was wondering how to stop having to depend on '@org_chromium_libcxx//:cxx', and :cxxabi in each cc_library rule. It seems pretty tiresome to me. Custom macros are an option, but I was wondering if there was a way to add it to the CROSSTOOL configuration instead.

sayrer commented 7 years ago

I agree this is not great.

I haven't figured out how to include these things in the toolchain without triggering a circular dependency. I'll keep thinking about the best way to automate it, though. Suggestions welcome!

sayrer commented 6 years ago

Have a proposed fix for this in https://github.com/vsco/bazel-toolchains/pull/12.

LMK if it works for you.

sayrer commented 6 years ago

Should be resolved now.