vsco / keys

Keys for Adobe Photoshop Lightroom
http://vsco.github.io/keys/
GNU General Public License v2.0
345 stars 63 forks source link

Lightroom Classic CC killed it 😢 #28

Open kanphoto opened 7 years ago

kanphoto commented 7 years ago

I installed LR C CC on a mac I dont use too often knowing that this might be a possibility.

I try to start Keys and the menu bar icon disappears after 1-2 seconds. Error logs attached below. I have tried everything that is suggested in past issue logs with no luck.

This might be the saddest day in my business. VSCO Keys has saved me hours upon hours of time. Does anyone have an alternative they use?

------------------------VSCOKeysErrorLog---------------------------------

2017-10-18 17:15:44 +0000 macbook-pro.home Exception: "AXParent" attribute unsupported by: <NSApplication: 0x6040001018c0>

( 0 VSCOKeys 0x0000000100001924 uncaughtExceptionHandler + 62 1 VSCOKeys 0x0000000100001f7c SetUpLogging + 0 2 ExceptionHandling 0x00007fff4b957fb5 -[NSExceptionHandler _handleException:mask :] + 417 3 ExceptionHandling 0x00007fff4b957b4b NSExceptionHandlerExceptionRaiser + 196 4 libobjc.A.dylib 0x00007fff702dec76 objc_exception_throw + 48 5 CoreFoundation 0x00007fff49974249 -[NSException raise] + 9 6 AppKit 0x00007fff46edbff9 NSAccessibilityAttributeValue + 169 7 AppKit 0x00007fff46f8f523 NSAccessibilityGetObjectForAttributeUsingLegacyAPI + 371 8 AppKit 0x00007fff46f8ea06 NSAccessibilityGetObjectValueForAttribute + 1367 9 AppKit 0x00007fff47327ab8 -[NSApplication accessibilityParent] + 41 10 AppKit 0x00007fff46f8e066 -[NSAccessibilityAttributeAccessorInfo getAttributeValue:forObject:] + 58 11 AppKit 0x00007fff47544f8f _NSAccessibilityEntryPointValueForAttribute_block_invoke.816.llvm.5385866E + 880 12 AppKit 0x00007fff47540e37 NSAccessibilityPerformEntryPointObject.llvm.5385866E + 16 13 AppKit 0x00007fff47541003 _NSAccessibilityEntryPointValueForAttribute.llvm.5385866E + 182 14 AppKit 0x00007fff472e8811 -[NSObject(NSAccessibilityInternal) _accessibilityValueForAttribute:clientError:] + 351 15 AppKit 0x00007fff4732a425 -[NSApplication(NSApplicationAccessibility) _accessibilityValueForAttribute:clientError:] + 49 16 AppKit 0x00007fff472ef474 CopyAppKitUIElementAttributeValueNoCatch + 98 17 AppKit 0x00007fff472ed0ae CopyAttributeValue + 172 18 HIServices 0x00007fff481ed231 _AXXMIGCopyAttributeValue + 282 19 HIServices 0x00007fff481f71ac _XCopyAttributeValue + 455 20 HIServices 0x00007fff481cf939 mshMIGPerform + 212 21 CoreFoundation 0x00007fff498f7219 CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION + 41 22 CoreFoundation 0x00007fff498f7165 CFRunLoopDoSource1 + 533 23 CoreFoundation 0x00007fff498eed50 __CFRunLoopRun + 2848 24 CoreFoundation 0x00007fff498edfa3 CFRunLoopRunSpecific + 483 25 HIToolbox 0x00007fff48c0d866 RunCurrentEventLoopInMode + 286 26 HIToolbox 0x00007fff48c0d5d6 ReceiveNextEventCommon + 613 27 HIToolbox 0x00007fff48c0d354 _BlockUntilNextEventMatchingListInModeWithFilter + 64 28 AppKit 0x00007fff46f0aa23 _DPSNextEvent + 2085 29 AppKit 0x00007fff4769fe6c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 30 AppKit 0x00007fff46eff831 -[NSApplication run] + 764 31 AppKit 0x00007fff46ece9d2 NSApplicationMain + 804 32 VSCOKeys 0x00000001000018d4 start + 52 )

----------------------------------VSCOKeysRunTrace---------------------------------------------- CRASH: "AXParent" attribute unsupported by: <NSApplication: 0x6040001018c0> Stack Trace: ( 0 VSCOKeys 0x0000000100001924 uncaughtExceptionHandler + 62 1 VSCOKeys 0x0000000100001f7c SetUpLogging + 0 2 ExceptionHandling 0x00007fff4b957fb5 -[NSExceptionHandler _handleException:mask :] + 417 3 ExceptionHandling 0x00007fff4b957b4b NSExceptionHandlerExceptionRaiser + 196 4 libobjc.A.dylib 0x00007fff702dec76 objc_exception_throw + 48 5 CoreFoundation 0x00007fff49974249 -[NSException raise] + 9 6 AppKit 0x00007fff46edbff9 NSAccessibilityAttributeValue + 169 7 AppKit 0x00007fff46f8f523 NSAccessibilityGetObjectForAttributeUsingLegacyAPI + 371 8 AppKit 0x00007fff46f8ea06 NSAccessibilityGetObjectValueForAttribute + 1367 9 AppKit 0x00007fff47327ab8 -[NSApplication accessibilityParent] + 41 10 AppKit 0x00007fff46f8e066 -[NSAccessibilityAttributeAccessorInfo getAttributeValue:forObject:] + 58 11 AppKit 0x00007fff47544f8f _NSAccessibilityEntryPointValueForAttribute_block_invoke.816.llvm.5385866E + 880 12 AppKit 0x00007fff47540e37 NSAccessibilityPerformEntryPointObject.llvm.5385866E + 16 13 AppKit 0x00007fff47541003 _NSAccessibilityEntryPointValueForAttribute.llvm.5385866E + 182 14 AppKit 0x00007fff472e8811 -[NSObject(NSAccessibilityInternal) _accessibilityValueForAttribute:clientError:] + 351 15 AppKit 0x00007fff4732a425 -[NSApplication(NSApplicationAccessibility) _accessibilityValueForAttribute:clientError:] + 49 16 AppKit 0x00007fff472ef474 CopyAppKitUIElementAttributeValueNoCatch + 98 17 AppKit 0x00007fff472ed0ae CopyAttributeValue + 172 18 HIServices 0x00007fff481ed231 _AXXMIGCopyAttributeValue + 282 19 HIServices 0x00007fff481f71ac _XCopyAttributeValue + 455 20 HIServices 0x00007fff481cf939 mshMIGPerform + 212 21 CoreFoundation 0x00007fff498f7219 CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION + 41 22 CoreFoundation 0x00007fff498f7165 CFRunLoopDoSource1 + 533 23 CoreFoundation 0x00007fff498eed50 __CFRunLoopRun + 2848 24 CoreFoundation 0x00007fff498edfa3 CFRunLoopRunSpecific + 483 25 HIToolbox 0x00007fff48c0d866 RunCurrentEventLoopInMode + 286 26 HIToolbox 0x00007fff48c0d5d6 ReceiveNextEventCommon + 613 27 HIToolbox 0x00007fff48c0d354 _BlockUntilNextEventMatchingListInModeWithFilter + 64 28 AppKit 0x00007fff46f0aa23 _DPSNextEvent + 2085 29 AppKit 0x00007fff4769fe6c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 30 AppKit 0x00007fff46eff831 -[NSApplication run] + 764 31 AppKit 0x00007fff46ece9d2 NSApplicationMain + 804 32 VSCOKeys 0x00000001000018d4 start + 52 )

HeyItsRay commented 7 years ago

Same issue! Not working now:( There have been several companies that have done key shortcuts but many of them have stopped supporting because of the time needed to keep up with new OS updates and new versions of lightroom make it not unprofitable for many companies to continue development. Pfixer does offer a solution but I currently have a support ticket that has been un-responded to for over a year with several attempts to update my questions and still no response! I even purchased their hardware which I found unusable for many reasons. If there was a company that would actually support I'd consider a monthly subscription.

## Update: I did hear back from the people at Pfixer. I opened a new ticket and they responded within the hour. My old ticket must have been lost. They said their software was also disabled with the new launch of Lightroom "classic" cc, but that they should have a working beta within the next 24 hours.

They have two options for lightroom keyboard shortcuts. The basic or "core" is $30 but is limited. The full keyboard shortcut is $100. They do offer free trials and have a VSCO layout you can load if you're used to the VSCO keys layout. I'm going to give it a try and see how it goes.

I will say I don't love that the key values are locked. So for example if you have "S" set to raise contrast you have to use the values they have pre-determined which is +10 contrast or if you hold Shift+S its +5. With VSCO you could change it to anything you wanted down to +1. Small thing but it bugs me on a few of the adjustments I would like to be smaller or bigger. When I asked they said that they would be adding that feature in v.2 of the software but don't have a release date yet. Good news is I guess that it's at least a feature that is on it's way eventually.

bakkerme commented 7 years ago

@HeyItsRay Out of interest, what's your workflow and how did you use Keys? I've been working on a project that allows users to manipulate Lightroom's sliders and select presets from an iPad or other tablet. It's been on the backburner lately since I wasn't sure it would be useful, but I'm hoping that learning a bit about other lightroom users would help me out on how to proceed. Your help would be highly appreciated.

5tarForge commented 7 years ago

In the meantime the best option is to just use the previous version of Lightroom CC (2015.12) which is what I'll be doing. I can't do without VSCO Keys, its integral to my workflow.

bwehman commented 7 years ago

Yep, same issue. It's not possible to go back to 2015.12 is it.

peterringenberg commented 7 years ago

@bwehman It is extremely easy to install the previous version of LR.

Just click the down arrow to the right of "Lightroom Classic CC" in the Adobe Creative Cloud app manager and select "Other Versions". I had to re-install and then update, but my previous version (and VSCO Keys!!!) are running again!!

Hopefully VSCO Keys can be updated so that it will work with LR Classic CC.

chrijam commented 7 years ago

Bummer! Hoping a brain can work out the programming!

cajames commented 7 years ago

Hey guys, I've added support for OSX in the PR above. Will try to get my hands on a Windows machine to upgrade the Windows version too. Not sure who maintains this repo, but if you want to download the OSX installer you can download the zip from https://github.com/cajames/keys/releases/tag/v2.0.1

peterringenberg commented 7 years ago

Oh my goodness!! I can’t wait to try this out. Thank you SOOOO much!!

On Nov 3, 2017, at 1:27 PM, Chris James notifications@github.com wrote:

Hey guys, I've added support for OSX in the PR above. Will try to get my hands on a Windows machine to upgrade the Windows version too. Not sure who maintains this repo, but if you want to download the OSX installer you can download the zip from https://github.com/cajames/keys/releases/tag/v2.0.1 https://github.com/cajames/keys/releases/tag/v2.0.1 — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vsco/keys/issues/28#issuecomment-341772430, or mute the thread https://github.com/notifications/unsubscribe-auth/AfdrlJs8krjorQObQwoM33-oOIR6L4Uzks5sy0zmgaJpZM4P-EOy.

benny-danny commented 7 years ago

@cajames YOU ARE THE MEN!!!! It's working great on Lightroom Classic, High Sierra. Teste on my iMac and Macbook Pro! Thanks a lot men!

cajames commented 7 years ago

No worries! 😄 Awesome in that case I'll try to push that to this repo so others can find it for now.

kanphoto commented 7 years ago

Sorry I did not respond to some questions. I've been shooting in Vietnam and India for work. Just catching up with all this. @cajames when I get back to the studio I will test it out. Can I "donate" some funds to you for this? You've honestly saved my ass if this works would love to help you out for your time!

vphamdev commented 7 years ago

https://github.com/vsco/keys/pull/29 was merged, thank you @cajames and everyone!

sharonki commented 7 years ago

@cajames I would love to donate some funds to you as well, if you could help me with the issue I reported in #31. I really need VSCOKeys to work for my professional photography workflow. Time is of the essence here in November.

vphamdev commented 7 years ago

Hi everyone, we merged @cajames 's pull request, can you confirm that it works for you? thanks!

josecorpas commented 7 years ago

You literally made my day! Thanks you for the solution!!

pablo1020 commented 6 years ago

@cajames - Great work! Will you have a chance to update it on Win 10?

kanphoto commented 6 years ago

@cajames when I start lightroom i get a message (screen grab attached) asking for my password. I do this and then VSCO Keys quits every time. I tried uninstalling and reinstalling and removing the Accessibility adding it back and the same issue happens. Any ideas?

Thanks!

screenshot 2017-12-15 07 19 50
cajames commented 6 years ago

@kanphoto sorry to hear you’re having a hard time getting it set up, I do agree it’s a bit of a cumbersome install process. I'll try laying out the steps here so others can follow too.

The first step, removing the old VSCO keys:

Then installing the new:

And that should do it, should run VSCOKeys when you open up Lightroom. Hope this solves it for you. The constant password-request should be resolved by adding VSCOKeys to your Security & Privacy settings as shown above.

Michael-Schultz commented 6 years ago

Thanks so much @cajames!

jaydesypants commented 6 years ago

@cajames - thank you so much for this! I'm thrilled that someone with the know-how is updated this LR plug-in - it's a powerful tool!

However, can you help me as I am not yielding the same install results as what you describe - I'm using OSX 10.12.6 and I have carried out the process twice and it still isn't working - the VSCO 'X' that usually shows up in the toolbar just doesn't appear for me to activate the Keys. Any thoughts? I'd appreciate any advice you might have!

jaydesypants commented 6 years ago

@cajames - actually, I tried it for a third time, and what I did differently was, in Security & Privacy, I noticed that VSCOKeys was already added to the permissions, so I unlocked the permissions page and toggled VSCOKeys OFF and then back ON. I then did the same in the Lightroom Plug-in manager, and there it was! Ready to roll! @cajames YOU ARE A LEGEND!

DFStockel commented 6 years ago

@cajames I'm having trouble with VSCO Keys since update Lightroom yesterday. If I have a profile other than Adobe Standard selected, as soon as I hit one of my remapped keys, it resets all settings. The same thing happens if I have any profile selected and a hit one of my VSCO Key presets. Is there any way you could look into this? Thank you!

CliveBlair commented 6 years ago

Hi @cajames it looks like you've done a great job for OSX users. Thanks for all your hard work. I'm using Windows 10. Any update on getting VSCO to work for windows?

salsero206 commented 6 years ago

Hello @cajames I did purchase VcoKeys years ago. One day VscoKeys stopped working and I found out it was not supported anymore. I was sad and I continued with my life and without VscoKeys.... Today April/23/2018 I was wondering if I could reinstall it and put on my Purchased DVD classic LR6.14 and my OX 10.12.6 and it worked following your uninstallation process and installation process.... It did not work at first but then i read @jaydesypants directions and I am happy to announce IT WORKS! thank you guys!! cheers! salsero206

salsero206 commented 6 years ago

@cajames is it possible to make it work on my windows 10 machine? thank you! cheers salsero206

CliveBlair commented 6 years ago

Just a quick update: I've got VSCO keys to work with Lightroom on Windows 10!

salsero206 commented 6 years ago

@CliveBlair I am wondering what LR version you own? I have LR6.14 thank you!

CliveBlair commented 6 years ago

I'm using Lightroom Classic CC, with the latest release 7.3

lukaszkruszec commented 6 years ago

Hi, @CliveBlair Could you share a working VSCO version for Windows 10 ?

CliveBlair commented 6 years ago

I simply used the latest opensource version 2.0 I downloaded from here. But the trick wasn't which version I used but how I installed it. I simply adapted the MAC info from @cajames above and it worked for me under windows 10.

The tricky part was mapping the keys. Currently vscokeys works a treat with raw files. But I can't yet work out how to control the temp/tint on jpegs, although all the other settings work. It's something to do with the missing raw profile. But I'm determined to get to the bottom of this.

akincansenol commented 6 years ago

Hi @CliveBlair,

I wonder how you could adapt @cajames MAC info. I've changed old files with the inside of source files on already installed vscokeys, Lightroom show plugin as before and under plug-in extra menu I've activated (it just show "active keys lr3") but it's not working. I would appreciate if you light me up.

heyklaus commented 6 years ago

Thank you very much for your work here @cajames. Works perfectly on my Mac. How can I pay you some beers or coffees? And may I pose one more question: is there a way to add custom layouts or to edit the .vkeys files? The .keysjson files seem to have gone, right? I work with the VSCOstandard profile but would like to change some keys ... Thanks again and keep your great work up!

skymakai commented 6 years ago

I just tried it and VSCOkeys won't even run. I see it for a flash in the Menubar, but then it's gone. (MacOS 10.13.6). I've tried both version 2.0 and 2.0.1.

CliveBlair commented 6 years ago

Although I got it working after jumping through many hoops, I've now moved away from VSCOkeys, as I've found an alternative for Windows that isn't left without support. LRKeys: https://lrkeys.com/

skymakai commented 6 years ago

If there's an alternative or fix for MacOS, I'd like to know.

skymakai commented 6 years ago

@cajames, have you got the current version working?

salsero206 commented 6 years ago

with all your respect to everyone... I build a new machine and Win10........... i need my VscoKeys................... but i can not buy this software anymore................. so i went and got me https://lrkeys.com/ 31.00 dollars...................... was a good price......... it works

On Wed, Sep 5, 2018 at 12:43 PM skymakai notifications@github.com wrote:

@cajames https://github.com/cajames, have you got the current version working?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vsco/keys/issues/28#issuecomment-418857052, or mute the thread https://github.com/notifications/unsubscribe-auth/Ak4F1yxIfOAVGxCcAc6HaGJRqg0LXpeMks5uYClngaJpZM4P-EOy .