search

vscode-elements / elements

Web component library for developing Visual Studio Code extensions
https://vscode-elements.github.io
MIT License
100 stars 18 forks source link

Few issues when migrating open source of Cloud Foundry Tools #163

Open veredcon opened 9 hours ago

veredcon commented 9 hours ago

Hi Adam,

This is a really cool and useful library that we would like to adopt in SAP instead of the deprecated one. Thank you for developing it!

After trying to adopt it in some open source we have I encountered few issues: https://github.com/SAP/cloud-foundry-tools/pull/296

  1. codicons are not presented well when inside a vscode-element control e.g.: image The paste icon at the end of the textfield cannot be displayed (if it is just outside of the vscode-element there is no issue)
  2. You can see I added some styles of Link component, If there was a vscode-link (like in https://github.com/estruyf/vscode-community-ui-toolkit/blob/main/src/link/index.ts) one would not have to take care of it...
  3. I have an issue migrating the vscode-single select and I don't understand why, I tried many things we have there 2 dropdowns that needs to be populated with the selected org and space once they appear.. for some reason I get the selected org as expected (option is selected) but not the selected space (the selected space is correct but not rendered in the spaces dropdown)..
  4. Also I noticed some errors in the console image

I would appreciate your assistance in adopting this lib so it could be chosen for the rest of our SAP repositories using the old webview toolkit.

Thanks!

bendera commented 2 hours ago

Hi Vered,

I can't answer all of your questions yet, but what I've found so far:

  1. The icon component isn't imported. The id="vscode-codicon-stylesheet" attribute is missing from the CSS link. See for examples: https://vscode-elements.github.io/components/icon/#basic-example