search

vscode-elements / elements

Web component library for developing Visual Studio Code extensions
https://vscode-elements.github.io
MIT License
156 stars 27 forks source link

Icons colors wash out in the lighter themes #172

Closed mikeburgh closed 1 month ago

mikeburgh commented 1 month ago

Using some of the light themes (all but Solarized Light and Light Visual Studio ) the icon colors wash out against the background.

Here is a video showing it:

https://github.com/user-attachments/assets/946a9ba8-cbf3-41ea-b185-5aa3c43fa2cf

mikeburgh commented 1 month ago

Sorry, was looking into the fix for a PR and found some wayward css on my end.. Cleaned up and sorted!

bendera commented 1 month ago

Great! Where does this cool datagrid component come from?

mikeburgh commented 1 month ago

It's AG Grid: https://www.ag-grid.com/

The extension we are building with it and vscode-elements is for database management (https://dbcode.io). I have not finished the page yet, but any modules we use we are giving lifetime subscriptions to any contributors/maintainers of them.. and yours is fantastic! , so if you uses databases and want a sub, let me know and I will get you a code.

bendera commented 1 month ago

if you uses databases and want a sub, let me know and I will get you a code

Yes, please, I would be honored.

Its UI is so beautiful. It doesn't look like a website, but like an integral part of VSCode.

mikeburgh commented 1 month ago

It would be my pleasure.. If you can install the extension and sign in via the Accounts view once you click the DBCode icon in the activity bar I can then assign the subscription to you!

That's the aim.. make it feel just like VSCode, but have all the features of the traditional DB tools.

bendera commented 1 month ago

Signed in with my github account.

Thank you!

mikeburgh commented 1 month ago

Thanks, applied!