Add rows and cols attributes to textarea

vscode-elements / elements

Web component library for developing Visual Studio Code extensions

https://vscode-elements.github.io

MIT License

157 stars 28 forks source link

Closed chrjorgensen closed 1 year ago

chrjorgensen commented 1 year ago

This PR adds new attributes rows and cols to the textarea element, so the user can specify the dimensions of the area displayed.

These attributes are available in https://github.com/microsoft/vscode-webview-ui-toolkit, but was missing in this framework. I think having these attributes here also makes this framework more complete.

I'm a newbie to webview framework coding, so it's quite possible that I have missed something...

bendera commented 1 year ago

Thank you for your contribution! I agree these attributes are missing. I will release a new version soon.