search

vscodenpa / testissues

Clone of the vscode issue stream.
43 stars 23 forks source link

Support theme-conditioned extension icons #318

Open vscodenpa opened 2 years ago

vscodenpa commented 2 years ago

Extensions can use galleryBanner to adjust the font and background colours on the Marketplace today, although this is not reflected inside VS Code. I'm assuming this is intentional, since rendering each extension based on extension author's choice, rather than based on user's choice of a theme would likely look odd. (someone correct me if I'm wrong here)

In both VS Code and Marketplace there is only 1 icon so most icons have to have a solid light or dark background to provide the contrast for a light or dark icon. When a black icon with transparent background is used, this results in invisible icon either in dark or light theme.

Screenshot 2022-05-19 at 14 27 48 Screenshot 2022-05-19 at 14 24 59

The only way around it is to serve the icon with solid white background, but that doesn't seem like an ideal solution.

More importantly there are contexts within both Marketplace and VS Code where rendering each extension differently just doesn't make sense - e.g. in search results.

Slightly related to https://github-com/microsoft/vscode/-/139556

vscodenpa commented 2 years ago

confidence for label themes: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for assignee misolori: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for label themes: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for assignee misolori: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for label themes: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for assignee misolori: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for label themes: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for assignee misolori: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for label themes: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for assignee misolori: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for label themes: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for assignee misolori: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for label themes: 0.6. does not meet threshold

vscodenpa commented 2 years ago

confidence for assignee misolori: 0.6. does not meet threshold