vscodenpa / testissues

Clone of the vscode issue stream.
43 stars 23 forks source link

Task input variables not resolved in command inputs #334

Open vscodenpa opened 2 years ago

vscodenpa commented 2 years ago

Issue Type: Bug

Given this task

        {
            "label": "Show Localhost",
            "command": "${input:showLocalhost}",
            "problemMatcher": []
        }

and these inputs


        {
            "id": "showLocalhost",
            "type": "command",
            "command": "simpleBrowser.show",
            "args": "http://localhost:${input:port}"
        },
        {
            "id": "port",
            "description": "Port to hit",
            "type": "promptString",
            "default": "8009"
        }

It does display the simple browser view, but the URL it is pointed to is http://localhost:${input:port} instead of prompting me to enter a port.

Documentation here is slightly vague in that it says "Specifically, only command, args, and options support variable substitution." but it doesn't mention if args from "Tasks" vs args from "Inputs" will have variable substitution. Taking the documentation literally, input args should also have variable substitution.

VS Code version: Code 1.67.1 (da15b6fd3ef856477bf6f4fb29ba1b7af717770d, 2022-05-06T12:37:03.389Z) OS version: Windows_NT x64 10.0.22000 Restricted Mode: No Remote OS version: Linux x64 5.4.186-113.361.amzn2int.x86_64

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-8665U CPU - 1.90GHz (8 x 2112)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.81GB (2.94GB free)| |Process Argv|-n --crash-reporter-id 5c6bfb0a-e814-44a2-a3e1-2a6e7807d072| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|SSH: | |OS|Linux x64 | |CPUs|Intel(R) Xeon(R) Platinum 8259CL CPU - 2.50GHz (16 x 3099)| |Memory (System)|62.03GB (25.95GB free)| |VM|0%|
Extensions (36) Extension|Author (truncated)|Version ---|---|--- project-manager|ale|12.5.0 beardedicons|Bea|0.18.0 custom-plain-text|und|1.0.0 auto-close-tag|for|0.5.14 auto-rename-tag|for|0.1.10 remote-ssh|ms-|0.80.0 remote-ssh-edit|ms-|0.80.0 remote-wsl|ms-|0.66.3 vs-qalc|nor|0.1.10 material-product-icons|PKi|1.3.0 vscode-jsp|pth|0.0.3 vscode-autohotkey|sle|0.2.2 codesnap|adp|1.3.4 vscode-json|and|1.5.0 vscode-lombok|Gab|1.0.1 beautify|Hoo|1.5.0 vscode-brazil|mar|0.46.0 vscode-uuid-generator|mot|0.4.1 date-hover-preview|nor|1.0.3 quick-regex-replacer|nor|1.0.5 vscode-configurable-shortcuts|nor|1.0.3 smithy-vscode|pep|0.9.0 errorlens|Phi|1.1.3 polacode|pnp|0.3.4 java|red|1.6.0 partial-diff|ryu|1.4.3 vscode-taskexplorer|spm|2.9.1 code-spell-checker|str|2.2.0 sort-lines|Tyr|1.9.1 vscodeintellicode|Vis|1.2.21 vscode-java-debug|vsc|0.40.1 vscode-java-dependency|vsc|0.19.1 vscode-java-pack|vsc|0.22.4 vscode-java-test|vsc|0.35.0 vscode-maven|vsc|0.35.1 markdown-all-in-one|yzh|3.4.3 (3 theme extensions excluded)
vscodenpa commented 2 years ago

confidence for label tasks: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee alexr00: 0.95. does meet threshold

vscodenpa commented 2 years ago

confidence for label tasks: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee alexr00: 0.95. does meet threshold

vscodenpa commented 2 years ago

confidence for label tasks: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee alexr00: 0.95. does meet threshold

vscodenpa commented 2 years ago

confidence for label tasks: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee alexr00: 0.95. does meet threshold

vscodenpa commented 2 years ago

confidence for label tasks: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee alexr00: 0.95. does meet threshold

vscodenpa commented 2 years ago

confidence for label tasks: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee alexr00: 0.95. does meet threshold