search

vscodenpa / testissues

Clone of the vscode issue stream.
43 stars 23 forks source link

Comments API: reply editor should not auto-close brackets unconditionally #353

Open vscodenpa opened 2 years ago

vscodenpa commented 2 years ago

When replying to a code review comment, the reply editor unconditionally auto-closes brackets. We have had complaints from users about editor.autoClosingBrackets not affecting this behavior (when set to never). We are not 100% convinced that editor.autoClosingBrackets should apply here, since conceptually, editing comments is different from editing code, so a separate setting for comments could be more flexible, but maybe also unnecessarily complex.

-145384 discusses specifying a language on CommentController to control other behavior like syntax highlighting (mainly plaintext vs Markdown). Since editor.autoClosingBrackets already supports using per-language settings, it might work well enough to just make editor.autoClosingBrackets also take effect in the comment reply editor.

vscodenpa commented 2 years ago

confidence for label comments: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee rebornix: 0.8. does meet threshold

vscodenpa commented 2 years ago

confidence for label comments: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee rebornix: 0.8. does meet threshold

vscodenpa commented 2 years ago

confidence for label comments: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee rebornix: 0.8. does meet threshold

vscodenpa commented 2 years ago

confidence for label comments: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee rebornix: 0.8. does meet threshold

vscodenpa commented 2 years ago

confidence for label comments: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee rebornix: 0.8. does meet threshold

vscodenpa commented 2 years ago

confidence for label comments: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee rebornix: 0.8. does meet threshold

vscodenpa commented 2 years ago

confidence for label comments: 0.9. does meet threshold

vscodenpa commented 2 years ago

confidence for assignee rebornix: 0.8. does meet threshold