[npm extension] top level npm_modules aren't excluded when detecting npm scripts in workspaces

[vscodenpa]

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.67.2 (user setup) Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5 Date: 2022-05-17T18:15:52.058Z Electron: 17.4.1 Chromium: 98.0.4758.141 Node.js: 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0.18363

In the course of investigating a Live Share performance issue we noticed an unusual amount of activity when we call: vscode.tasks.fetchTasks() against our Live Share workspace. The issue is that we include node_modules in the top level of our workspace file. The NPM extension isn't currently filtering this top level folder out - only node_module subfolders. I'm not sure if this is by design as perhaps it was thought that users would never include this folder in their workspace? But we did - so perhaps others have too.

Steps to Reproduce:

1. Open a workspace that contains a large _nodemodules folder:

"folders": [ { "path": "." }, { "path": "../node_modules" } ],

2. Call vscode.tasks.fetchTasks() from the extension.

[vscodenpa]

confidence for label tasks: 0.85. does meet threshold

[vscodenpa]

confidence for assignee alexr00: 0.65. does not meet threshold

[vscodenpa]

confidence for label tasks: 0.85. does meet threshold

[vscodenpa]

confidence for assignee alexr00: 0.65. does not meet threshold

[vscodenpa]

confidence for label tasks: 0.85. does meet threshold

[vscodenpa]

confidence for assignee alexr00: 0.65. does not meet threshold

[vscodenpa]

confidence for label tasks: 0.85. does meet threshold

[vscodenpa]

confidence for assignee alexr00: 0.65. does not meet threshold

[vscodenpa]

confidence for label tasks: 0.85. does meet threshold

[vscodenpa]

confidence for assignee alexr00: 0.65. does not meet threshold