search

vsdudakov / fastadmin

FastAdmin is an easy-to-use Admin Dashboard App for FastAPI/Flask/Django inspired by Django Admin.
https://vsdudakov.github.io/fastadmin/
MIT License
137 stars 15 forks source link

Migrate to pydantic settings for FastAdmin configuration #35

Closed bswck closed 1 year ago

bswck commented 1 year ago

Since pydantic is a hard dependency, why not?

Summary

Adds validation of configuration

bswck commented 1 year ago

I just noticed an intended removal of pydantic dependency in the issues and PRs which turns this PR into nonsense. Feel free to either merge this PR or correct the pyproject.toml file that mislead me.

vsdudakov commented 1 year ago

I had pydantic settings before, but decided to remove dependency from pydantic, cause for some cases we can use fastadmin for django/flask and we don't want/need pydantic dependency here.

vsdudakov commented 1 year ago

Let me remove pydantic from toml

vsdudakov commented 1 year ago

Also it makes sense to use ADMIN prefix for settings cause could be some correlation with settings on projects which uses fastadmin

vsdudakov commented 1 year ago

Raised a ticket https://github.com/vsdudakov/fastadmin/issues/37