Correct the mocking to prevent network calls

vsecades / AbuseIpDb

AbuseIpDB - Wrapper around the AbuseIPDb service API

MIT License

15 stars 4 forks source link

Correct the mocking to prevent network calls #14

Closed Eorhim closed 4 years ago

Eorhim commented 4 years ago

Unfortunately I overlooked the fact, that the tests made network calls. By changing the mocking from Response.raise_for_status to requests.request we now prevent that.

Downside to this are slightly wrong tests, as we now don't reach the invocation of raise_for_status.

Eorhim commented 4 years ago

Will it re-open against development branch.