search

vsedach / mouse-copy

LispM/MCL style one-click mouse copy for GNU Emacs
http://carcaddar.blogspot.com/2011/01/mouse-copy-for-emacs.html
Other
22 stars 5 forks source link

Submit to MELPA #2

Open Wilfred opened 6 years ago

Wilfred commented 6 years ago

This is a neat little package, and it would be nice to see it on MELPA.

vsedach commented 6 years ago

Thank you! That is a good idea.

alphapapa commented 6 years ago

Not that it's a big deal for trivial code like this, but there is a minor license conflict: this package says it's ISC, yet says it's adapted from GPL code.

vsedach commented 6 years ago

Yes, I overlooked that.

After learning more about licensing and doing some thinking, it seems nonsensical in principle to release extensions to GNU Emacs that are not licensed under the GPL.

alphapapa notifications@github.com writes:

Not that it's a big deal for trivial code like this, but there is a minor license conflict: this package says it's ISC, yet says it's adapted from GPL code.

Wilfred commented 6 years ago

Uh, so I was compiling Emacs today, and noticed that this is already built-in to Emacs! https://github.com/emacs-mirror/emacs/blob/master/lisp/mouse-copy.el

I really appreciate your package for helping me discover it, but perhaps it doesn't need to be on MELPA :)

vsedach commented 6 years ago

That is mouse-drag-, which is enabled by default. I did not know about that when I first wrote mouse-copy.el. It does something quite different. Maybe instead of submitting to MELPA I should get around to doing my FSF copyright assignment paperwork and submit a patch for Emacs.

Wilfred Hughes notifications@github.com writes:

Uh, so I was compiling Emacs today, and noticed that this is already built-in to Emacs! https://github.com/emacs-mirror/emacs/blob/master/lisp/mouse-copy.el

I really appreciate your package for helping me discover it, but perhaps it doesn't need to be on MELPA :)

Wilfred commented 6 years ago

Commands in mouse-copy.el aren't enabled by default, but I see they're slightly different. mouse-drag-secondary-pasting requires you to M-down-mouse-1 and drag the region you want, and it's inserted at point.

This package uses the sexp you've just clicked on, saving you from needing to drag across the sexp.

It's definitely more convenient with this package, but since core Emcs already has a mouse-copy.el, this package will need to be renamed before MELPA I suspect.

vsedach commented 6 years ago

It's definitely more convenient with this package, but since core Emcs already has a mouse-copy.el, this package will need to be renamed before MELPA I suspect.

Here is what I would like to do:

Rewrite this functionality as new code that extends Emacs' mouse-copy.el and submit it as a patch for inclusion into Emacs.

There are many things wrong with this code (like the use of error). I would also like to have these features:

  1. Use secondary selection face for highlighting the s-exp about to be copied.
  2. Customization group and better documentation.
  3. Look into adding other mouse actions from ZWEI/Zmacs.

I can't promise this will be done soon, but I would like to do it (I even bought a mouse again last week, in anticipation of the work, after almost a decade of pointing stick use). Thank you for showing interest in this code, and for calling my attention to Emacs' mouse-copy.el

Vladimir