Inconsistencies and referencing in the JSON and the .h file

vsf-tv / gccg-api

Draft API for the Ground-Cloud-Cloud-Ground Working Group: https://vsf.tv/Ground-Cloud-Cloud-Ground.shtml

BSD 2-Clause "Simplified" License

4 stars 2 forks source link

Inconsistencies and referencing in the JSON and the .h file #23

Closed pac-work closed 5 months ago

pac-work commented 7 months ago

Naming inside the JSON is ambiguous at places (firstField vs. evenField for video vs. anc.)
The code still refers to the CDI at some places (AWS CDI-SDK, CdiAvmTxCallback)

jmailhot commented 6 months ago

the naming of the fields is indeed fraught with peril. we crossed this bridge in 2110-20 and defined it a specific way, probably best here to follow that.

mhhen commented 6 months ago

Will change both references to something like:

            "field": 0,          ## Zero or one. For interlaced, zero= first field, one= second field. ##
                                 ## For progressive, shall be set to zero, except in the case of progressive ##
                                 ## segmented frame data where it indicates the segment. ##

References to "CDI" will be removed.

pac-work commented 5 months ago

Thanks, great!