search

vsg-dev / MyFirstVsgApplication

Very simple project to illustrate how to build a VulkanSceneGraph application
MIT License
30 stars 12 forks source link

Use cmake macros provided by vsg #6

Closed rhabacker closed 3 years ago

rhabacker commented 3 years ago

See vsg-dev/VulkanSceneGraph#305 for details

rhabacker commented 3 years ago

I just saw that this package does not have the maintainer options defined, I will add that and update this branch.

robertosfield commented 3 years ago

I am merging, but quite look through it feels a bit verbose for a small example project that is intended to show barebones cmake required to build a VSG application, adding non standard cmake scripts gets in the way of this,

Once I do the full review of the vsgMacros I'll make a decision on whether MyFirstVsgApplication should be treated differently.

rhabacker commented 3 years ago

adding non standard cmake scripts gets in the way of this,

You do not want to tag releases for this repo ? That is provided by the add_option_maintainer macro.

robertosfield commented 3 years ago

This is a simple example for end users, not a library that will be regularly updated. We don't need to maximize convenience for things that very rarely happen. The priority with code example is a minimal example of how to set up cmake to build a VSG.