vec4.h operator != typo bug

vsg-dev / VulkanSceneGraph

Vulkan & C++17 based Scene Graph Project

http://www.vulkanscenegraph.org

MIT License

1.32k stars 212 forks source link

Closed dchristopherfennell closed 4 years ago

dchristopherfennell commented 4 years ago

Hello,

vsg/maths/vec4.h has a typo bug with the != operator.

return lhs[0] == rhs[0] || lhs[1] != rhs[1] || lhs[2] != rhs[2] || lhs[3] != rhs[3];

should be

return lhs[0] != rhs[0] || lhs[1] != rhs[1] || lhs[2] != rhs[2] || lhs[3] != rhs[3];

And now that I look at it, so does vec2.h, vec3.h

Thanks, DC

robertosfield commented 4 years ago

Ooops. Classic copy and paste error duplicated three times.

Thanks for spotting the error. I've just checked in a fix: