16uhrpasing commented 3 years ago

Hi,

I'm using the VulkanSDK 1.2.176.1 and the latest version of VSG. If I compile my shaders with the glslangValidator and use them via vsg::ShaderStage::read, everything works fine. If I use the exact same source code as a const char * via ShaderStage::create, the program breaks.

Reproduce in vsgdraw from vsgExamples:

const auto vertShader = R"(

version 450

layout(push_constant) uniform PushConstants { mat4 projection; mat4 modelview; } pc;

layout(location = 0) in vec3 inPosition; layout(location = 0) out vec3 fragColor; layout(location = 1) in vec3 inColor; layout(location = 1) out vec2 fragTexCoord; layout(location = 2) in vec2 inTexCoord;

void main() { gl_Position = (pc.projection pc.modelview) vec4(inPosition, 1.0); fragColor = inColor; fragTexCoord = inTexCoord; } )";

const auto fragShader = R"(

version 450

layout(binding = 0) uniform sampler2D texSampler;

layout(location = 0) out vec4 outColor; layout(location = 1) in vec2 fragTexCoord; layout(location = 0) in vec3 fragColor;

void main() { outColor = texture(texSampler, fragTexCoord)*vec4(fragColor,1.0f); } )";

replace the "//load shaders" ShaderStage::read call with auto vertexShader = vsg::ShaderStage::create(VK_SHADER_STAGE_VERTEX_BIT, "main", vertShader); auto fragmentShader = vsg::ShaderStage::create(VK_SHADER_STAGE_FRAGMENT_BIT, "main", fragShader);

-> vsg::Exception at memory location XYZ

compile the exact same source with glslangValidator to the .spv format and use in ShaderStage::create -> works

robertosfield commented 3 years ago

Could you provide a full .cpp that recreates the problem, copying pasting parts of possible example that recreates a problems is really prone to deviation between the copy and pasting and what you have, so the results I might get could well diverge and won't have any means of checking what you fully mean,

Also could you provide a stack trace, and details of your OS & hardware.

16uhrpasing commented 3 years ago

Sorry for the delay, here are the tests I did with the corresponding stack traces and a README. shader error VSG.zip

robertosfield commented 3 years ago

Thanks for the zip file. I have begun investigating. The insource version works for me - I'm using Linux, latest VSG/vsgXchange master, NVidia drivers and VulkanSDK 1.2.162.0, but it creates a Vulkan debug error, running the vsgdraw I see that it's also generating a Vulkan debug error, but I this Vulkan debug error looks unrelated to the issue you're seeing so I'll follow that one up separately. The error is:

UNASSIGNED-CoreValidation-DrawState-InvalidRenderArea(ERROR / SPEC): msgNum: 1149387633 - Validation Error: [ UNASSIGNED-CoreValidation-DrawState-InvalidRe nderArea ] Object 0: handle = 0x90000000009, type = VK_OBJECT_TYPE_RENDER_PASS; | MessageID = 0x44824371 | Cannot execute a render pass with renderArea not within the bound of the framebuffer. RenderArea: x 0, y 0, width 1280, height 1024. Framebuffer: width 1280, height 1016. Objects: 1

I think this particular error is due to the Window manager resizing the window after it's been created, and the state setup not handling this resize. I will just need to strep through the vsgdraw code to see what needs to be update - this example used to run without Vulkan debug errors so it might be recent VukanSDK are just a bit tighter.

The vsgonv/source.cpp version crashes for me, initially via an exception due to the shader files not being found, then once I fixed the path issue a seg fault in the NVidia driver. My track trace looks like:

0 0x00007fffedf2acf2 in ?? () from

/lib/x86_64-linux-gnu/libnvidia-glvkspirv.so.465.27

1 0x00007fffedf73540 in _nv008nvvm () from

/lib/x86_64-linux-gnu/libnvidia-glvkspirv.so.465.27

2 0x00007ffff5a1bc8f in ?? () from