Closed tomhog closed 5 years ago
I have just checked out the PR. It fails to build because ShaderUtils.h is not included in the PR, could you add this.
Added, not sure what is going on with VS, did the same thing again. Excluded it from the source control. Maybe I need to check the .gitignore but surely that's not blocking .h files. I'll be more wary of it now.
On Wed, 30 Jan 2019 at 15:20, Vulkan made easy notifications@github.com wrote:
I have just checked out the PR. It fails to build because ShaderUtils.h is not included in the PR, could you add this.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vsg-dev/osg2vsg/pull/6#issuecomment-458982892, or mute the thread https://github.com/notifications/unsubscribe-auth/AAW1ASs4HVu0GAD940nL1lg1cJVLKRCyks5vIbg3gaJpZM4aaSHa .
I have checked in a fix to the .gitignore - it had include/ in there. I think this might be an erroneous merge from the original work on vsgFramework. I'll now have a bash at the merge.
I now get a bit further but fail in the cmake .:
-- Failed to find Shaderc
Will have a look at the Find script.
Pull request to see if you can redirect