search

vsg-dev / vsgImGui

Integration of VulkanSceneGraph with ImGui
MIT License
43 stars 28 forks source link

Change to queue produces crash in debug mode #19

Closed rolandhill closed 2 years ago

rolandhill commented 2 years ago

This change //init_info.Queue = *(_queue); // ImGui doesn't use the queue so no need to assign it.

in commit 7e94aad551a74ab3e9ac35eb6558fa795a75752e causes vsgImGui to crash in debug mode because ImGui makes the following assertion in vsgImGui/src/imgui/backends/imgui_impl_vulkan.cpp

ImGui_ImplVulkan_Init() ... IM_ASSERT(info->Queue != VK_NULL_HANDLE); ...

Removing the comment to set the queue appears to fix the problem, but not sure if this will cause a problem anywhere else. Removing the assertion isn't as practical because it's within the Imgui library.

robertosfield commented 2 years ago

I've added back in queue assignment of the queue to fix, I've added an comment to explain why the code is in there:

b93f2037a7170455cedc0694e5e25fe8168c1ad9