search

vsg-dev / vsgImGui

Integration of VulkanSceneGraph with ImGui
MIT License
43 stars 28 forks source link

WIP Map vsg to ImGui keys. Change key events to io.AddKeyEvent() #32

Closed rolandhill closed 1 year ago

rolandhill commented 1 year ago

The way ImGui handles keyboard input has changed around version 1.87 or 1.88. This draft PR builds and runs, but the key events don't appear to do anything within ImGui. I have:

The translation looks to be working OK and there are no errors, but the ImGui demo doesn't echo the characters in the text box.

A discussion of the changes is here https://github.com/ocornut/imgui/issues/4921

The new way of handling keys looks to be much easier - maybe too easy and I haven't understood it. Could you also cast an eye over it.

Roland

robertosfield commented 1 year ago

@rolandhill I have merged the changes from @kannode as they look more inclusive. I'll close this PR as I believe it's no longer required. Let me know if there is something amiss with vsgImGui master.

rolandhill commented 1 year ago

Thanks, Robert. All looks good. I'll send a few more PRs based on @kannode's work to fix minor details.

Roland

On Mon, 16 Jan 2023 at 04:17, Robert Osfield @.***> wrote:

@rolandhill https://github.com/rolandhill I have merged the changes from @kannode https://github.com/kannode as they look more inclusive. I'll close this PR as I believe it's no longer required. Let me know if there is something amiss with vsgImGui master.

— Reply to this email directly, view it on GitHub https://github.com/vsg-dev/vsgImGui/pull/32#issuecomment-1383204676, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPOEQ4EXZSOIVFDMWBAYLTWSQWJRANCNFSM6AAAAAASVFMIH4 . You are receiving this because you were mentioned.Message ID: @.***>