[BUG] [Decision Tree] Small issues of splitting & feature generating functions

vsha96 / mllib

Machine Learning in Haskell

BSD 3-Clause "New" or "Revised" License

29 stars 1 forks source link

[BUG] [Decision Tree] Small issues of splitting & feature generating functions #17

Open s1m0000n opened 2 years ago

s1m0000n commented 2 years ago

Describe the bug There are several small todos in makeSplit, makeBestSplitsForFeatures, generateFeatures, findBestSplitByFeatureWithParams

To Reproduce Run & check behavior of makeSplit, makeBestSplitsForFeatures, generateFeatures, findBestSplitByFeaturesWithParams

Additional context Test cases on the issues should probably be added #5

vsha96 commented 2 years ago

Explanation: There are several functions that need to be tested more They are called in the following sequence (I tried to display dependencies with indents)

-- `makeSplit`
--   `makeBestSplitsForFeatures`
--     `generateFeatures`
--     `findBestSplitByFeatureWithParams`

Problem: These are the main functions for fitting the model, I'm afraid something may not be taken into account

P.S.: you can use development_Tree_Decision.ipynb as a playground and see how these functions work