search

vsha96 / mllib

Machine Learning in Haskell
BSD 3-Clause "New" or "Revised" License
29 stars 1 forks source link

Add separate configuration for KNN #24

Closed s1m0000n closed 7 months ago

s1m0000n commented 1 year ago

Working on #7

vsha96 commented 1 year ago

Thank you 👍 I'll review it during the week

s1m0000n commented 1 year ago

Will try to devote time to the project on the following weekend

On 19 Mar 2023, at 21:13, Ivan Shulyugin @.***> wrote:

@vsha96 commented on this pull request.

On src/Mllib/Model.hs https://github.com/vsha96/mllib/pull/24#discussion_r1141439357:

the same as above

— Reply to this email directly, view it on GitHub https://github.com/vsha96/mllib/pull/24#pullrequestreview-1347544402, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANLUTRCKGPMFIJQWKOP5WGLW45EDJANCNFSM6AAAAAAVZXIXGU. You are receiving this because you authored the thread.

vsha96 commented 7 months ago

1 year... it's time to review 🦾

vsha96 commented 7 months ago

I will clean everything related to KMeans, need to make these changes in another PR