vshcherbyna / igel

UCI compatible chess engine
GNU General Public License v3.0
92 stars 9 forks source link

Add missing includes. No functional change. #285

Closed skiminki closed 1 year ago

skiminki commented 1 year ago

Couple of sources files that use fixed-width integer types such as std::uint32_t are missing the include to \<cstdint>. This breaks the build on Ubuntu 23.10 (GCC 13.2), so add the missing includes.

bench: 19300902

**

I noticed the build breakages when upgrading my openbench build container from Ubuntu 23.04 to 23.10. I'd guess that previously some of the system headers were including stdint.h/cstdint directly which hid this issue. Anyway, the fix is pretty trivial.

Fixed this by grepping 'int32_t' and adding include \<cstdint> to files with hits, except the fathom sources. In general, it is often considered a good practice not depend on transitive includes (e.g., arguably nnue.cpp shouldn't need the include because nnue.h already does the include), so I added these also to the .cpp files even if not strictly needed.

I'll comment the one change in types.h inline.