vshn / appcat-service-postgresql

AppCat Service Provider for PostgreSQL
https://vshn.github.io/appcat-service-postgresql/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Deploy Helm release from a custom resource #27

Closed ccremer closed 2 years ago

ccremer commented 2 years ago

Summary

Checklist

Reviewer Notes

zugao commented 2 years ago

I was able to test a bit differently the PR then the suggested approach make test-integration local-install install-samples. After simply issuing make local-install I created manually myself the CRDs and it turned out the ProviderConfig was missing which in the end prevented the postgresql instance to be deployed. After a short discussion with @ccremer we have agreed that it's ok at this step that the ProviderConfig would miss and the testing with samples was valid in the end. From my side the code looks good even though I had been missing some business logic that @ccremer gladly explained later to me.