vshn / appcat-service-postgresql

AppCat Service Provider for PostgreSQL
https://vshn.github.io/appcat-service-postgresql/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Fix deep-merging of helmvalues if values are not 'map[string]interface' #57

Closed ccremer closed 2 years ago

ccremer commented 2 years ago

Summary

We are not doing type V map[string]interface{} anymore as this breaks type assertion when deep-merging. For example, if m is V then ok in vals, ok := m.(map[string]interface{} will be false. To ensure that m is actually map[string]interface{}, we do a type alias with type V = map[string]interface{} instead (notice the = sign vs type V map[string]interface{}).

To group the available utility methods, I have moved everything into its own helmvalues package

Checklist