vshn / appcat-service-postgresql

AppCat Service Provider for PostgreSQL
https://vshn.github.io/appcat-service-postgresql/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Refactoring and Cleanup code #97

Closed ccremer closed 2 years ago

ccremer commented 2 years ago

Summary

Refactored the standalone pipelines:

The "create" and "update" have been consolidated, there is now just 1 pipeline. This makes it easier to understand, the pipeline also follows better the idempotency design as expected by Kubernetes. Also, there is no "first" and "2nd pass" anymore to determine the readiness of dependent resources.

The result is a lot less code to understand and maintain overall, at the cost of somewhat added complexity for idempotency in the individual steps.

Functionally, no changes are expected.

Checklist

ccremer commented 2 years ago

as discussed internally, we'll not do a full code review here. It has been tested though and it seems to be working more stable than with different pipelines and "passes"