vshn / component-appcat

BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Broken image reference in explanation `Manage secrets not coming from a provider` #85

Closed simu closed 1 year ago

simu commented 1 year ago

Original report in https://github.com/projectsyn/component-hub/issues/68 by @arska:

https://hub.syn.tools/appcat/explanations/crossplane-secrets-non-provider.html references an image at https://hub.syn.tools/appcat/_images/crossplane-secrets.png which does not exist. The original https://github.com/vshn/component-appcat/blob/master/docs/modules/ROOT/pages/explanations/crossplane-secrets-non-provider.adoc references the image at https://github.com/vshn/component-appcat/raw/master/docs/modules/ROOT/pages/explanations/crossplane-secrets.png where it does exist.

Reproduce

Actual Behavior

Image reference in the rendered documentation page (https://hub.syn.tools/appcat/explanations/crossplane-secrets-non-provider.html) is broken.

Expected Behavior

Image is displayed in the rendered documentation page. Please note that Antora expects images to be present in docs/modules/ROOT/assets/images and not alongside the Asciidoc pages, see e.g. https://github.com/vshn/billing-collector-cloudservices/

wejdross commented 1 year ago

https://github.com/vshn/component-appcat/pull/209

wejdross commented 1 year ago

fixed with #209