vshn / odootools

VSHN-specific Odoo tool suite
https://odootools.vshn.net
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Auto-generate assets on dependency upgrades #118

Closed mhutter closed 2 years ago

mhutter commented 2 years ago

Will prevent linter errors like in #117

Summary

Checklist

github-actions[bot] commented 2 years ago

🚀 Preview deployment active

App URL https://odootools-pr-118-vshn-odoo-test.apps.cloudscale-lpg-2.appuio.cloud
Revision 739573bf7a7bff72dd8fe32b1de878de7f0660b9
Helm release vshn-odoo-test/odootools-pr-118
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

ccremer commented 2 years ago

Unfortunately postupgradetasks only works on self-hosted renovate (presumable due to security concerns), not as GH app... https://docs.renovatebot.com/configuration-options/#postupgradetasks

ccremer commented 2 years ago

As an alternative, we might consider to .gitignore the bootstrap files. we just need to ensure that make generate runs before building the binary (especially in GH actions), because of embedding the files in embed.go, as they need to be present when building.

mhutter commented 2 years ago

Ah, that makes sense. Should I amend to implement your proposal then?

ccremer commented 2 years ago

Yes please, if you're basteling on it :smile:

github-actions[bot] commented 2 years ago

🚀 Preview deployment active

App URL https://odootools-pr-118-vshn-odoo-test.apps.cloudscale-lpg-2.appuio.cloud
Revision a6faf53135784dd5202b18888e8757274d5215e6
Helm release vshn-odoo-test/odootools-pr-118
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 2 years ago

✔️ Preview deployment uninstalled

Helm release vshn-odoo-test/odootools-pr-118
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443