Add option to set display name to service name

vshn / signalilo

Forward alerts from Prometheus Alertmanager to Icinga2 via Webhooks

BSD 3-Clause "New" or "Revised" License

71 stars 24 forks source link

Add option to set display name to service name #121

Closed dragoangel closed 1 year ago

dragoangel commented 1 year ago

Resolves #119

Checklist

[x] Keep pull requests small so they can be easily reviewed.
[x] Update the README.
[x] Categorize the PR by setting a good title and adding one of the labels: bug, enhancement, documentation, change, breaking, dependency as they show up in the changelog
[x] Link this PR to related issues.

dragoangel commented 1 year ago

It will allow see multiply alerts which previously was hidden behind same service name in Nagstamon like this:

Not the best way, but one which worked, that I had in mind.

dragoangel commented 1 year ago

Hi @simu, can you add a new release tag to docker image and update the helm chart repo version when you will have time, please? Thank you for quick code review and merge.

simu commented 1 year ago

@dragoangel I've now created a new release tag (v0.13.0). If you're using Helm, you should be able to use the new flag through Helm value extraEnvVars.

dragoangel commented 1 year ago

@dragoangel I've now created a new release tag (v0.13.0). If you're using Helm, you should be able to use the new flag through Helm value extraEnvVars.

Thank you 👍, yes I yesterday already used extraEnvVars with the latest flag and before it used own repo for test.