search

vshymanskyy / StandWithUkraine

#StandWithUkraine banner and related documents
https://stand-with-ukraine.pp.ua
Creative Commons Zero v1.0 Universal
1.4k stars 289 forks source link

Round corners of the flag #247

Closed viktor-yakubiv closed 11 months ago

viktor-yakubiv commented 1 year ago

It's a minor visual change that makes the banner integrate into the Github's UI a litte bit nicer.

Thank you for the banner and for considering my contribution.

webknjaz commented 1 year ago

I'm not sure if that's the right thing to do since the banner is not only shown on the web, but in the mobile app too. It's not only used in repo readmes, but in other locations like the sponsors pages. It's not only used on GitHub even — I've put it up on the StackOverflow profile page..

So I guess my question/concern is whether it'll work well in all the contexts and if it'll be problematic in places using differ themes (GH has a few dark mode themes, SO is also dark).

viktor-yakubiv commented 1 year ago

Dark mode can be addressed with a slight transparency but this is not ideal, of course. Unfortunately, media queries inside SVG is ignored by the browser, so there is no way to handle this natively. In any case, the banner uses official colors of the Ukrainian flag, and therefore it's not appropriate to change them according to the theme.

The corner radius is very subtle. On the mobile, it won't be noticable, so effectively does nothing. On wider screens, it would just look a little bit better.

I've checked your Stack Overflow profile, it would look good there, as well as on other web pages I could think of. Most of the websites round corners nowadays.

I would completely understand rejecting this PR if authors find the change unsuitable for all the use cases in the Web. What do you think?

webknjaz commented 1 year ago

I'm fine with it but I'll leave the final decision to @vshymanskyy.