search

vshymanskyy / TinyGSM

A small Arduino library for GSM modules, that just works
GNU Lesser General Public License v3.0
1.91k stars 713 forks source link

Compile error because streamSkipUntil() is a protected constuctor #456

Open u4mzu4 opened 3 years ago

u4mzu4 commented 3 years ago

[X ] I have read the Troubleshooting section of the ReadMe

What type of issues is this?

[ ] Request to support a new module

[ X] Bug or problem compiling the library [ ] Bug or issue with library functionality (ie, sending data over TCP/IP) [ ] Question or request for help

What are you working with?

Modem: SIM800 Main processor board: ESP32 TinyGSM version: 0.10.8 Code:

modem.sendAT(GF("+FTPPUT=1")); response = modem.waitResponse(); delay(2500); modem.streamSkipUntil(','); modem.streamSkipUntil(','); lengthOfDataStr = modem.stream.readStringUntil('\n'); lengthOfDataInt = lengthOfDataStr.toInt();

Scenario, steps to reproduce

Cut response message from library without any String operation

Expected result

It was working in February 2020, but not on nowdays

Actual result

streamSkipUntil is protected

Debug and AT command log

gasagna commented 1 year ago

I agree that this limits the use of the modem for sending other AT commands than those that have already been implemented. Other functions such as streamGetIntBefore or streamGetFloatBefore are really useful in custom code to parse the response to some AT commands, but we can't really use them.

Can these functions be made part of the public interface? What is the reason for them to be marked as protected?