search

vshymanskyy / TinyGSM

A small Arduino library for GSM modules, that just works
GNU Lesser General Public License v3.0
1.96k stars 726 forks source link

First SIM808 bluetooth support commit. Template class and basic functionality #488

Closed adrianca88 closed 3 years ago

adrianca88 commented 3 years ago

I have added some basic functionality on SIM808 bluetooth. I have also code for scanning bluetooth devices, pairing and connect (but I need to refactor it before open a new merge request).

It is important to disable bluetooth if you don't need it because it is enabled by default (and consuming power)

Please, do not hesitate giving me some corrections or recommendations if it's necessary.

SRGDamia1 commented 3 years ago

Sorry for the slow response. Everything looks pretty good to me. I'm assuming you've tested it and it works; I don't have an 808/868 to test myself.

Do you want me to accept this or wait until you have the rest of it ready?

adrianca88 commented 3 years ago

Sorry for the slow response. Everything looks pretty good to me. I'm assuming you've tested it and it works; I don't have an 808/868 to test myself.

Hello. Yes, I'm currently working on a project that uses SIM808 and it works well.

Do you want me to accept this or wait until you have the rest of it ready?

I think it's better to merge this basic functionality (I have a lot of work this days and I'm not sure when I will be able to add the rest of code).

adrianca88 commented 3 years ago

I'll try to put also a small sample app on next PR