Typo in example Diagnostics - Githubissues

vshymanskyy / TinyGSM

A small Arduino library for GSM modules, that just works

GNU Lesser General Public License v3.0

1.93k stars 715 forks source link

Typo in example Diagnostics #517

Closed woodlist closed 3 years ago

woodlist commented 3 years ago

[x] I have read the Troubleshooting section of the ReadMe

What type of issues is this?

[ ] Request to support a new module

[ ] Bug or problem compiling the library [x] Bug or issue with library functionality (ie, sending data over TCP/IP) [ ] Question or request for help

What are you working with?

Modem: Main processor board: TinyGSM version: Code:

Scenario, steps to reproduce

Expected result

Actual result

Debug and AT command log

Line 161: GSM_PIN is not boolean type and could not be compared with integer 3. It is senseless.

SRGDamia1 commented 3 years ago

It's not being compared to 3, line 161 just checks if GSM_PIN has been defined as anything valid. The sim status is compared to 3.