search

vshymanskyy / TinyGSM

A small Arduino library for GSM modules, that just works
GNU Lesser General Public License v3.0
1.93k stars 715 forks source link

src/TinyGsmClientSequansMonarch.h: use PDP context #1 #546

Open ffontaine opened 3 years ago

ffontaine commented 3 years ago

PDP Context #1 is working perfectly with GMS01Q

Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com

SRGDamia1 commented 3 years ago

I'm fairly certain I was using context 3 because on the VZM20Q contexts one and two are pre-set to Verizon configurations so 3 is the first available. Does context 3 not work on the other module? If context 3 does work for it and the change is just more-or-less cosmetic, I don't want to change it.

ffontaine commented 3 years ago

PDP context #3 is mostly working, there is a single issue with one the embedded applet which does not work as expected because it assumes that thee is a single PDP context. Do you think it would be acceptable to update this PR to allow an advanced user to configure its PDP context?

SRGDamia1 commented 3 years ago

@ffontaine - could you set the context number as a define/pre-processor flag? That would allow anyone to change it if necessary without forcing them to set it if they don't want to.