UTF8 values are not working.

vshymanskyy / blynk-library-js

Blynk library for JS. Works with Browsers, Node.js, Espruino.

https://blynk.io/

MIT License

215 stars 67 forks source link

Open vshymanskyy opened 7 years ago

vshymanskyy commented 7 years ago

Need to check why Unicode notifications are not working and provide a fix/example.

heisice commented 7 years ago

self.sock.write(data, 'binary');

then the unicode string is broken. but

self.sock.write(data, 'utf-8');

this is ok. please review.

vshymanskyy commented 7 years ago

This doesn't look like a good solution for me...

self.sock.write(data)

also sends headers and other binary data, that we don't want to be encoded to UTF8

ristomatti commented 6 years ago

Any update on this?

bestpika commented 5 years ago

Any update on this?