search

vshymanskyy / blynk-library-python

Blynk library for Python. Works with Python 2, Python 3, MicroPython.
https://blynk.io/
MIT License
281 stars 97 forks source link

Modify the function of the same name #24

Closed SilvesterHsu closed 5 years ago

SilvesterHsu commented 5 years ago

Blynk has the same function _send as its parent class BlynkProtocol. When BlynkProtocol is ready to send data, self.conn.send(data) in the Blynk class cannot be called because of the same name function _send in the BlynkProtocol class. Therefore, the socket does not send any data, which will raise connection failure.

I noticed that in the recent commits, you modified the function name, causing the function to have the same name issue.

chrissv commented 5 years ago

Suggest a better name, instead of just removing the underscore. Maybe something like "msgSend"

vshymanskyy commented 5 years ago

Sorry, this was fixed already