Closed vsimon closed 8 years ago
Regarding -v MSVSVER, I see my mistake. With 'nounset' set, a way that should work is:
if [ -n "${MSVSVER:-}" ]; then
I am testing.
For readlink, just wanted an absolute path. OUTDIR=$(cd $OUTDIR && pwd -P)
may suffice (OSX, linux works I think that would also work on Windows).
A reasonable solution for the -v MSVSVER problem that works is:
MSVSVER=${MSVSVER:-} if [ -n MSVSVER ]; then export GYP_MSVS_VERSION=$MSVSVER fi
I will create a pull request.
Looks good.
Just tested it and the conditional always hit on OSX, due to the missing $ var reference, -n tests for a not-zero length string...perhaps something like this?
if [ -n "$MSVSVER" ]; then export GYP_MSVS_VERSION=$MSVSVER fi
I am testing your solution (-n "$MSVSVER") under Ubuntu, which is all I have this afternoon. It seems to work so far.
Great, thank you!
The solution -n "$MSVSVER" works under Ubuntu 16.04.
With https://github.com/vsimon/webrtcbuilds/pull/19 merged, good to close.