search

vsivsi / meteor-file-collection

Extends Meteor Collections to handle file data using MongoDB gridFS.
http://atmospherejs.com/vsivsi/file-collection
Other
159 stars 37 forks source link

Is jquery required #153

Closed DavidSichau closed 7 years ago

DavidSichau commented 7 years ago

I want to avoid to deliver jquery to my clients. However your package depends on jquery, however I do not find any reference in the code to jquery. Is it actually really required and where?

Can you point me to the code which requires jquery, such that I can generate a pull request without jquery dependecy.

vsivsi commented 7 years ago

Hi, It didn't used to be, but at some point resumable.js apparently added a dependency on it in this pull request. https://github.com/23/resumable.js/pull/343

Then they apparently reversed that on this issue. This thread would be funny if it wasn't so sad... https://github.com/23/resumable.js/issues/344

Anyway, looks like it isn't really a dependency so I'll remove it in the next release (later this week).

As a side note, I'd really like to make resumable.js a fully optional dependency of this project so that better (and better managed) upload solutions such as tus or flowjs could be (also optionally) supported. Someday...

DavidSichau commented 7 years ago

@vsivsi Thanks for the fix, when is it planed to be released?

vsivsi commented 7 years ago

I'll do it before this weekend.

vsivsi commented 7 years ago

Just released and published to atmosphere in version 1.3.8