Closed xc8tlik closed 8 years ago
Hi, thanks for the thorough and well researched issue report. This is a Meteor issue. They implemented their check
function that way... I'm sure there must be some good reason. This issue will likely affect all apps/packages that implement Meteor methods and do proper argument type checking... It's a pretty obscure problem, but if there is going to be a change, it should probably be in the Meteor codebase.
Agreed, if nothing else perhaps this will help any late-night Googlers in future. Thanks for all your good work.
Code to reproduce:
Example error message:
Root cause:
_DDPMethod_jobSave()
/check()
>testSubtree()
>isPlainObject()
> check inif
statement forobj.nodeType
Suggested solution:
Easiest thing to do is document that you can't have a
nodeType
property in thedata
object. Maybe this is such an unlikely scenario that you don't want to overcomplicate the docs or code?Either way, thought I would bring it to your attention! Feel free to close.