vsivsi / meteor-job-collection

A persistent and reactive job queue for Meteor, supporting distributed workers that can run anywhere.
https://atmospherejs.com/vsivsi/job-collection
Other
388 stars 68 forks source link

Broken with Meteor 1.5 #237

Closed ujwal-setlur closed 7 years ago

ujwal-setlur commented 7 years ago

I updated my meteor 1.4 project to 1.5, and job-collection seems broken:

W20170602-09:49:38.449(-7)? (STDERR) Error: JobQueue: Invalid root, must be nonempty string
W20170602-09:49:38.452(-7)? (STDERR)     at new JobQueue (packages/vsivsi_job-collection/job/src/job_class.coffee:114:17)
W20170602-09:49:38.454(-7)? (STDERR)     at job/src/job_class.coffee.js:175:45
W20170602-09:49:38.454(-7)? (STDERR)     at Function.JobQueue [as processJobs] (packages/vsivsi_job-collection/job/src/job_class.coffee:110:18)
W20170602-09:49:38.455(-7)? (STDERR)     at meteorInstall.imports.startup.server.startup-cron-jobs.js (imports/startup/server/startup-cron-jobs.js:25:5)
W20170602-09:49:38.456(-7)? (STDERR)     at fileEvaluate (packages/modules-runtime.js:333:9)
W20170602-09:49:38.457(-7)? (STDERR)     at require (packages/modules-runtime.js:228:16)
W20170602-09:49:38.459(-7)? (STDERR)     at meteorInstall.imports.startup.server.index.js (imports/startup/server/index.js:1:201)
W20170602-09:49:38.463(-7)? (STDERR)     at fileEvaluate (packages/modules-runtime.js:333:9)
W20170602-09:49:38.468(-7)? (STDERR)     at require (packages/modules-runtime.js:228:16)
W20170602-09:49:38.471(-7)? (STDERR)     at meteorInstall.server.main.js (server/main.js:1:14)
W20170602-09:49:38.475(-7)? (STDERR)     at fileEvaluate (packages/modules-runtime.js:333:9)
W20170602-09:49:38.476(-7)? (STDERR)     at require (packages/modules-runtime.js:228:16)
W20170602-09:49:38.476(-7)? (STDERR)     at /Users/ujwal/Work/grubmobile/gm-server/.meteor/local/build/programs/server/app/app.js:5809:1
W20170602-09:49:38.477(-7)? (STDERR)     at /Users/ujwal/Work/grubmobile/gm-server/.meteor/local/build/programs/server/boot.js:338:34
W20170602-09:49:38.477(-7)? (STDERR)     at Array.forEach (native)
W20170602-09:49:38.479(-7)? (STDERR)     at Function._.each._.forEach (/Users/ujwal/.meteor/packages/meteor-tool/.1.5.0.ptpcut++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/underscore/underscore.js:79:11)
=> Exited with code: 1
vsivsi commented 7 years ago

I'm away on a trip and won't be able to look into this until mid-June.

ujwal-setlur commented 7 years ago

Any updates on this? I could look into this if I had a pointer on where to start. Thanks!

vsivsi commented 7 years ago

I just upgraded the job-collection playground app from Meteor 1.4.2.3 to Meteor 1.5 without any issues. This seems like an issue that is specific to your app/code, which I obviously don't have access to.

ujwal-setlur commented 7 years ago

OK, I will look more into it and send you a code snippet of how I am using the package.

Get Outlook for iOShttps://aka.ms/o0ukef


From: Vaughn Iverson notifications@github.com Sent: Monday, July 3, 2017 11:37:34 AM To: vsivsi/meteor-job-collection Cc: Ujwal Setlur; Author Subject: Re: [vsivsi/meteor-job-collection] Broken with Meteor 1.5 (#237)

I just upgraded the playground app from Meteor 1.4.2.3 to Meteor 1.5 without any issues. This seems like an issue that is specific to your app/code, which I obviously don't have access to.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/vsivsi/meteor-job-collection/issues/237#issuecomment-312711155, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFkMXbo-pdRHvkSK2ydyC-_mfgAb7BJ3ks5sKTTugaJpZM4NujdA.

vsivsi commented 7 years ago

I really need a full minimal reproduction app to proceed in helping with any debugging like this. Just dropping a code snippet on me to review will not be a good use of either of our time, I need running code and instructions that clearly reproduce the issue with a minimum of effort on my part. Sorry to be such a stickler, but I've wasted untold hours trying to remotely debug other people's code only to have it be something that had nothing to do with my code.

ujwal-setlur commented 7 years ago

Yes, no worries. I am used to receiving and analyzing bug reports as well. I will put up a skeleton app.

Get Outlook for iOShttps://aka.ms/o0ukef


From: Vaughn Iverson notifications@github.com Sent: Monday, July 3, 2017 2:50:36 PM To: vsivsi/meteor-job-collection Cc: Ujwal Setlur; Author Subject: Re: [vsivsi/meteor-job-collection] Broken with Meteor 1.5 (#237)

I really need a full minimal reproduction app to proceed in helping with any debugging like this. Just dropping a code snippet on me to review will not be a good use of either of our time, I need running code and instructions that clearly reproduce the issue with a minimum of effort on my part. Sorry to be such a stickler, but I've wasted untold hours trying to remotely debug other people's code only to have it be something that had nothing to do with my code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/vsivsi/meteor-job-collection/issues/237#issuecomment-312739480, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFkMXcJo9aHDXwKKstUIf1tQ3wlqQ_sGks5sKWIsgaJpZM4NujdA.

ujwal-setlur commented 7 years ago

I resolved the issue by replacing Job.processJobs() with jc.processJobs(). Thanks for looking into this. This was an application code error. Apologies!

vsivsi commented 7 years ago

No worries, glad you figured it out!