search

vsivsi / meteor-job-collection

A persistent and reactive job queue for Meteor, supporting distributed workers that can run anywhere.
https://atmospherejs.com/vsivsi/job-collection
Other
388 stars 68 forks source link

added typings file for typescript projects #245

Open mibto opened 7 years ago

mibto commented 7 years ago

this file is helpful for all typescript users. I created it because i got the same error than: https://github.com/vsivsi/meteor-job-collection/issues/232

vsivsi commented 7 years ago

Hi, thanks for this. I'm not a Typescript user but just looking at it I can tell that you put a nontrivial amount of work into those declarations!

My main concern with this is that it becomes another thing that needs to be kept up-to-date as the package evolves. But there are no tests to somehow verify or flag when that may be have become an issue. (I understand that actually doing that without replicating all of the unit tests in Typescript may be difficult).

Also, this package is highly dependent on the meteor-job npm package, and a lot of what is defined here perhaps belongs there (either in addition to, or instead of here).

I don't know enough about Typescript to judge the best way to divvy the declarations up between the two packages...

mibto commented 7 years ago

Hi :) sorry i was in holidays for 2 weeks. i see your point about the maintenance. An other way would be that i publish the typings on https://github.com/DefinitelyTyped/DefinitelyTyped so that everybody can install and update this typing definition from there. If you like this idea more, then let me know and maybe you can add a word about it in your readme.

vsivsi commented 7 years ago

At first glance, DefinitelyTyped seems like the way to go. Any drawbacks to that approach that you can think of?

mibto commented 7 years ago

sounds good for me. i'll let you know when it's done.

pedrofg commented 6 years ago

Does it have a solution at this point?