search

vsivsi / meteor-job-collection

A persistent and reactive job queue for Meteor, supporting distributed workers that can run anywhere.
https://atmospherejs.com/vsivsi/job-collection
Other
388 stars 68 forks source link

Coffeescript v2 support? #264

Open benlavalley opened 6 years ago

benlavalley commented 6 years ago

There are some breaking changes between Coffeescript v1 and v2 - I tried to figure them out to get job-collection compatible with v2, but I know little to nothing about Coffeescript and don't use many of Javascript's advanced capabilities yet, so I couldn't figure out making all the necessary changes.

Figured I'd pose the question about having job-collection updated to support v2 before it goes into it's maintenance mode come January.

vsivsi commented 6 years ago

Thanks for the heads-up on this. I'm not writing a lot of CS these days, but I'll look into this and see if the required changes are straightforward or not. Based on the claims in the CS 2.0 announcement, it shouldn't be too crazy.

mitar commented 6 years ago

I just had to update all my packages to CoffeeScript 2. Meteor does not allow both CoffeeScript 1 and CoffeeScript 2 to coexist at the same time in the same app.

I could try to do a PR, but I see that this package is in maintenance only mode.

vsivsi commented 6 years ago

NP. I’ll accept a PR for that.

mitar commented 6 years ago

Done.